Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
M
mfang2.0
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 92
    • Issues 92
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • 魔方Web开发组
  • mfang2.0
  • Issues
  • #217

Closed
Open
Opened Sep 14, 2021 by mengxiangchen@mengxiangchen
  • Report abuse
  • New issue
Report abuse New issue

[建议]配置结果增加注释

以下是部分建议完善注释的地方以 XXXX 标出,帮忙看看是不是合适

  1. XTLF配置,增加对工作电流配置说明
    /* Initial XTLF */
    FL_RCC_XTLF_SetWorkCurrent(FL_RCC_XTLF_WORK_CURRENT_450NA);  /* XXXX */
  1. XTHF配置,增加对0x7U配置说明
    /* Initial XTHF */
    FL_RCC_XTHF_WriteDriverStrength(0x7U);  /* XXXX */
  1. PLL配置,增加对目标输出频率说明 /* Initial PLL XXXX */ FL_RCC_PLL_Disable(); FL_RCC_PLL_SetClockSource(FL_RCC_PLL_CLK_SOURCE_XTHF); FL_RCC_PLL_SetPrescaler(FL_RCC_PLL_PSC_DIV12); FL_RCC_PLL_WriteMultiplier(63);
  2. 系统时钟配置,增加对 Flash延时、系统时钟 说明
    /* Initial System Clock */
    FL_FLASH_SetReadWait(FLASH, FL_FLASH_READ_WAIT_2CYCLE);     /* XXXX */
    FL_RCC_SetSystemClockSource(FL_RCC_SYSTEM_CLK_SOURCE_PLL);  /* XXXX */

建议参考车规要求,注释采用 /* */形式 另外,fm33lc0xx_fl_rcc.h里面,不少的宏定义,字母的大小写有点混用,0x5C5CAABBU,0x2fU 这种都有,要不要统一一下?

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
0
Labels
None
Assign labels
  • View project labels
Reference: fmsh-web-develop/mfang2.0#217